Hi Luca,
Thanks for this patch. Thanks for having learned the Gnulib conventions
regarding modules etc.
I plan to install this patch in your name, when the copyright paperwork
is complete.
Just four notes:
* The last line of m4/sd-dlopen.m4 currently ends without a newline.
* In the module description
> +Description:
> +Emit ELF notes for dependencies loaded with dlopen.
I'd better write "package dependencies" instead of "dependencies".
Just for clarity.
* We have the habit of installing a new module and its tests through
separate commits [1][2]. I would thus split your patch in two, at
the moment of installing it — if you don't do it already.
* In the tests, given the complexity of the asm and its macrology,
I would find it useful to have a test that verifies that the
contents of the .note.dlopen section. To this effect, use a shell
script (suffix .sh) as a test, extract the section's contents
through 'objdump' or 'readelf', and compare it with an expected
string.
Bruno
[1]
https://gitweb.git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commit;h=7ffbb1f4fe48aa66b67191bfd6f2da9a2fa1ec39
[2]
https://gitweb.git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commit;h=766f86918b8d558293894b65a0653317c2bbc879
