Hi Ondrej,
How did you test your patch? When I run
$ ./gnulib-tool --create-testdir --dir=../testdir1 --single-configure \
acl-permissions copy-file qcopy-acl qset-acl supersede acl
(with autoconf 2.71), I get two warnings:
autoheader: warning: missing template: USE_XATTR
autoheader: warning: Use AC_DEFINE([USE_XATTR], [], [Description])
This patch fixes them. But I would have expected that you fix it before
you submit the patch.
2023-01-13 Bruno Haible <br...@clisp.org>
qcopy-acl: Avoid autoconf warning.
* m4/xattr.m4 (gl_FUNC_XATTR): Provide a description in AC_DEFINE.
Also, protect against unsafe use of a configure option value.
diff --git a/m4/xattr.m4 b/m4/xattr.m4
index 6efdfa475a..5cbfc86002 100644
--- a/m4/xattr.m4
+++ b/m4/xattr.m4
@@ -1,5 +1,5 @@
# xattr.m4 - check for Extended Attributes (Linux)
-# serial 4
+# serial 5
# Copyright (C) 2003-2021 Free Software Foundation, Inc.
# This file is free software; the Free Software Foundation
@@ -16,7 +16,7 @@ AC_DEFUN([gl_FUNC_XATTR],
LIB_XATTR=
AC_SUBST([LIB_XATTR])
- if test "$use_xattr" = "yes"; then
+ if test "$use_xattr" = yes; then
AC_CHECK_HEADERS([attr/error_context.h attr/libattr.h])
use_xattr=no
if test "$ac_cv_header_attr_libattr_h" = yes \
@@ -36,7 +36,8 @@ AC_DEFUN([gl_FUNC_XATTR],
AC_MSG_WARN([AC_PACKAGE_NAME will be built without xattr support.])
fi
fi
- if test $use_xattr = yes; then
- AC_DEFINE_UNQUOTED([USE_XATTR], 1)
+ if test "$use_xattr" = yes; then
+ AC_DEFINE([USE_XATTR], [1],
+ [Define to 1 to use the Linux extended attributes library.])
fi
])
