Pádraig Brady <p...@draigbrady.com> writes: >> Thanks for the comment. Here is a tentative patch based on the >> PostgreSQL patches. Perhaps it might require a copyright assignment >> from the original author (Cc'ed). > > Is AC_CHECK_FUNCS sufficient to find pthread_is_threaded_np()? > I.E. is LIB_PTHREAD required to find this function on darwin?
Good point. It is detected on 10.8 without -lpthread, but maybe the link flag is needed on older versions of Mac OS X. I'll fix it in the next version. > It's tempting to simplify actually and unconditionally call > the forked version, as this isn't a function that would > be in a hot path. I agree, since this function is mainly called from libintl_setlocale, which is called at very early stage in typical programs, and probably we can assume that there is only one thread at that point. Regards, -- Daiki Ueno