Excerpts from Bruno Haible's message of Wed Nov 30 05:29:14 -0500 2011: Hi Bruno,
> Your patches look pretty good. In parallel to the tweaking of the > last details, it will be useful to assign the copyright for the > change to the FSF. This is needed because Gnulib is central to many > GNU packages. Thanks for the great feedback. I'm implementing the fixes for issues you noted and testing them. I'll submit them shortly (hopefully tomorrow as I won't get to test on cygwin tonight). The only point I'm not clear on is the note about using a fixed size array allocation instead of the dynamic one. Is it acceptable to use HOST_NAME_MAX + 1 to achieve a size that is known to the compiler at compile time or did you have some other non-malloc mechanism in mind? Each patch should also update Changlog as well, correct? I think that the patch to add test-sethostname would be best as a fourth patch since it can't be used until the unistd integration is done. The alternate would be to squash 2 and 3 of this series into a single patch at which point the test suite could be updated as well. What is the preferred method? > To go ahead with this, please fill in the form in the file > gnulib/doc/Copyright/request-assign.future (if you foresee making > more contributions to Gnulib) or > gnulib/doc/Copyright/request-assign.changes (if this will be your > only contribution) and send it to the FSF. I've sent the request for this paperwork. Thanks -Ben -- Ben Walton Systems Programmer - CHASS University of Toronto C:416.407.5610 | W:416.978.4302
