Jim Meyering wrote: > Bruno Haible wrote: >>> The change to lib/set-mode-acl.c fixed the first test failure. For the >>> second test failure, I'm applying this fix: >> >> And finally, clean up the pieces of unused Solaris code: >> >> 2011-09-05 Bruno Haible <br...@clisp.org> >> >> acl: Clean up Solaris code. >> * lib/acl-internal.h: Remove no-op #if. >> * lib/file-has-acl.c: Likewise. >> * lib/set-mode-acl.c (qset_acl): Remove unused Solaris code. >> * lib/copy-acl.c (qcopy_acl): Likewise. > > Very nice series of changes. > I've confirmed that with these (though not yet with your latest irix > fix) changes, all coreutils tests pass on both Fedora 15 and Solaris 10. > > Thanks for all that work!
Oops. There was actually one failure on Solaris 10: FAIL: test-copy-acl-1.sh (exit: 1) ================================== + test 1 = 0 + func_tmpdir + : /var/tmp tmp=/var/tmp/glj4aWlm + test -n /var/tmp/glj4aWlm + test -d /var/tmp/glj4aWlm + pwd builddir=/home/1007/gu/meyering/coreutils-8.12.193-72030/gnulib-tests + cd /home/1007/gu/meyering/coreutils-8.12.193-72030/gnulib-tests + cd /var/tmp/glj4aWlm + rm -f tmpfile[0-9] tmpaclout[0-2] + echo Simple contents + chmod 600 tmpfile0 acl_flavor=none + test -f /sbin/chacl + func_test_copy tmpfile0 tmpfile1 + echo Simple contents + chmod 600 tmpfile1 + /home/1007/gu/meyering/coreutils-8.12.193-72030/gnulib-tests/test-copy-acl tmpfile0 tmpfile1 + /home/1007/gu/meyering/coreutils-8.12.193-72030/gnulib-tests/test-sameacls tmpfile0 tmpfile1 error accessing the ACLs of file tmpfile0 Abort - core dumped + exit 1 + exit 1 If it's still reproducible with your latest version, I'll debug it.
