> > So, in summary, there are two problems:
> >   - 'cp' creates a nontrivial ACL for a directory when the original
> >     directory had none.
> > ...
> This patch fixes it. I'm committing it in gnulib.

We shouldn't need coreutils tests in order to detect that a gnulib module
is not working well. I'm extending the ACL tests in gnulib so that they
detect the failure before the fix:

  mode = 4700: tmpfile1 got an ACL
  FAIL: test-set-mode-acl-2.sh
  files tmpfile0 and tmpfile1: different ACL entry #2: different ids -1 and 0
  FAIL: test-copy-acl-2.sh

Basically, it's enough to try different values of TMPDIR, instead of always
trying only TMPDIR=/tmp.


2011-09-05  Bruno Haible  <br...@clisp.org>

        copy-file: Try unit tests on more file systems.
        * tests/test-copy-file-1.sh: New file.
        * tests/test-copy-file-2.sh: New file.
        * modules/copy-file-tests (Files): Add them.
        (Makefile.am): Add them to TESTS.

        acl: Try unit tests on more file systems.
        * tests/test-file-has-acl-1.sh: New file.
        * tests/test-file-has-acl-2.sh: New file.
        * tests/test-set-mode-acl-1.sh: New file.
        * tests/test-set-mode-acl-2.sh: New file.
        * tests/test-copy-acl-1.sh: New file.
        * tests/test-copy-acl-2.sh: New file.
        * modules/acl-tests (Files): Add them.
        (Makefile.am): Add them to TESTS.

-- 
In memoriam Moshe Weinberg <http://en.wikipedia.org/wiki/Moshe_Weinberg>

Reply via email to