-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 According to Bruno Haible on 12/11/2009 9:39 AM: > It's weird that the dup_safer_flag and fd_safer_flag get defined if the > module 'unistd-safer' AND the module 'cloexec' are included. If a package > needs pipe_safer and set_cloexec_flag, why should it compile dup_safer_flag > and fd_safer_flag? > > Everything becomes simpler when there is a clear relation > "need function X => must request module Y" > for every C function X.
Yes, that is a reasonable reorganization. > 2009-12-11 Bruno Haible <br...@clisp.org> > > New module 'fd-safer-flag'. > * lib/dup-safer-flag.c: New file, extracted from lib/dup-safer.c. > * lib/dup-safer.c (dup_safer_flag): Remove function. > * lib/fd-safer-flag.c: New file, extracted from lib/fd-safer.c. > * lib/fd-safer.c (fd_safer_flag): Remove function. > * lib/unistd-safer.h (dup_safer_flag, fd_safer_flag): Update condition. > * modules/cloexec (configure.ac): Drop indicator macro. > * modules/fd-safer-flag: New file. > * modules/pipe2-safer (Depends-on): Add fd-safer-flag. Remove cloexec. > * modules/stdlib-safer (Depends-on): Add fd-safer-flag. > * modules/unistd-safer-tests (Depends-on): Add fd-safer-flag. Looks fine to me. I'll rebase my fcntl patch to go on top of this. - -- Don't work too hard, make some time for fun as well! Eric Blake e...@byu.net -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAksinuoACgkQ84KuGfSFAYCCMgCfTvSj8kQ69u0G2esjSu6uvMeU PzkAoJNxCnSRXWvkphas4O01VLdn+3Fm =2+y8 -----END PGP SIGNATURE-----
