Reuben Thomas wrote: > On Mon, 6 Apr 2009, Jim Meyering wrote: > >> Ok by me. Though I don't like the use of $(C_SOURCES), as I >> mentioned. I do understand you're trying to do this gradually. I'd >> be inclined to make bigger changes ;-) It's only "make >> syntax-check", after all. > > OK, I'm just trying to make changes that I can make reasonably > confidently in little time and others review ditto! > >> Also, your change lacks a recent improvement: >> >> http://git.sv.gnu.org/cgit/coreutils.git/commit/?id=100d4983e77dc >> >> The file-name-filtering grep commands (that test whether we have any >> file to search) should all use -l, since all that matters is the >> 0/non-zero exit status; no sense in finding/printing all matches. > > OK, in fact this only applies to one comment and one invocation of > grep in my patch (the ChangeLog rule changes I can't use since they > expect to have a complete list of files to look at and I only have C > files at the moment). > > Once this patch is in gnulib, I'll try to make another containing the > rest of the syntax checks.
Ok. Post "git format-patch ..." output and I'll push it, unless someone objects in the mean time.
