Simon Josefsson wrote:
> Refactoring seems like a good thing.  Your proposed two modules/
> directory split didn't strike me as the obvious way to go, but I
> haven't really thought about it.

Yes, a categorization according to topic, like James proposes, was
also my first thought. But some modules are hard to classify this way
(would you put 'clean-temp' into the same group as 'atexit' or as the
filesystem functions?).

> Btw, a lot of modules would go away of I moved all crypto-related
> stuff into a separate directory.  There is:
> 
> [EMAIL PROTECTED]:~/src/gnulib$ ls modules/gc*
> modules/gc                  modules/gc-md2-tests
> modules/gc-arcfour          modules/gc-md4
> modules/gc-arcfour-tests    modules/gc-md4-tests
> modules/gc-arctwo           modules/gc-md5
> modules/gc-arctwo-tests     modules/gc-md5-tests
> modules/gcd                 modules/gc-pbkdf2-sha1
> modules/gc-des              modules/gc-pbkdf2-sha1-tests
> modules/gc-des-tests        modules/gc-random
> modules/gc-hmac-md5         modules/gc-rijndael
> modules/gc-hmac-md5-tests   modules/gc-rijndael-tests
> modules/gc-hmac-sha1        modules/gc-sha1
> modules/gc-hmac-sha1-tests  modules/gc-sha1-tests
> modules/gc-md2              modules/gc-tests
> [EMAIL PROTECTED]:~/src/gnulib$
> 
> And plus modules for each of the underlying modules (e.g., arcfour,
> arctwo, des, md2, md5, ...) plus their test modules.
> 
> I propose to move these modules to modules/crypto/

Maybe it is wise to consider the dependency structure when creating this
subdirectory? The 'md4' module is not dependent on the other crypto modules,
and the other crypto modules don't depend on the 'md4' module. Why should
it then be put in the same directory? [I'm not sure, really. Just playing
the devil's advocate.]

> and all the *.{c,h} files to lib/crypto/.

Whether to use subdirectories in lib/, is an independent choice. It's your
choice, too.

> If the m4/ directory supports sub-directories,
> moving the *.m4's to m4/crypto/ would be nice too.

I don't think it does. One would need to pass extra -I flags to 'aclocal'.
gnulib-tool doesn't do this yet.

Bruno



Reply via email to