Hello Jim,

> Thanks for proposing that, but all of these additions to EXTRA_DIST
> are redundant with existing AC_LIBOBJ and AC_REPLACE_FUNCS directives
> in .m4 files.
> 
> 
> How about a change to gnulib-tool, now?  It would extract all
> AC_LIBOBJ symbols, derive the corresponding source names, and add
> them to the generated Makefile.am.

Thanks for this proposal; this is effectively what I did by hand now
(and it's why I missed 'error' and 'obstack' - thanks Eric for the
correction).

The rule "take all AC_LIBOBJ and AC_REPLACE_FUNCS arguments and append .c"
would work. automake does it like this. But we can get the list of files
in a simpler way. The complete list of files is already in the module
description. The rule "take all lib/* entries from the 'Files' section,
minus the lib_SOURCES from the 'Makefile.am' section" is simpler. I'll
implement that in gnulib-tool tomorrow.

> It passed "make distcheck" with only one additional kludge.
> The above mistakenly added lib/tmpfile-safer.c to the list,
> even though coreutils doesn't use the file.
> It was pulled in due to this unused macro in stdio-safer.m4:
> 
>   AC_DEFUN([gl_TMPFILE_SAFER],
>   [
>     AC_LIBOBJ([tmpfile-safer])
>   ])

Well, the 'tmpfile-safer' module uses this macro.

> I would hate to institutionalize a process that requires us to
> maintain all of these names in two places -- even temporarily.

Wait until tomorrow...

Bruno


Reply via email to