Yoann Vandoorselaere <[EMAIL PROTECTED]> writes: > On Sat, 2006-06-17 at 21:02 +0200, Simon Josefsson wrote: >> Hi Yoann! Ok to install this? Gnulib assumes that sys/types.h >> exists, and inet_ntop never tested HAVE_SYS_TYPES_H anyway. > > Hi Simon, > > Did you make sure that removing the sys/types.h requirement doesn't > break the build on some platform, like FreeBSD 4.x ?
Hi! sys/types.h is still included by the source code, what I did was to remove the autoconf test for sys/types.h, because the HAVE_SYS_TYPES_H CPP symbol wasn't used and isn't needed. Gnulib assumes that sys/types.h exists on all platforms, so we shouldn't test for it. > Currently, my GnuLib repository use the attached patch so that compile > doesn't fail on these system where sys/types.h is a requirement for > sys/socket.h inclusion. Interesting! I've installed your patch. Thanks. > Regards, > > -- > Yoann Vandoorselaere | Responsable R&D / CTO | PreludeIDS Technologies > Tel: +33 (0)8 70 70 21 58 Fax: +33(0)4 78 42 21 58 > http://www.prelude-ids.com > ? modules/ftw > Index: modules/socklen > =================================================================== > RCS file: /cvsroot/gnulib/gnulib/modules/socklen,v > retrieving revision 1.4 > diff -u -r1.4 socklen > --- modules/socklen 18 Jan 2006 08:52:56 -0000 1.4 > +++ modules/socklen 19 Jun 2006 11:00:08 -0000 > @@ -13,6 +13,7 @@ > Makefile.am: > > Include: > +#include <sys/types.h> > #include <sys/socket.h> > > License: > Index: modules/sys_socket > =================================================================== > RCS file: /cvsroot/gnulib/gnulib/modules/sys_socket,v > retrieving revision 1.1 > diff -u -r1.1 sys_socket > --- modules/sys_socket 10 Jan 2006 14:28:53 -0000 1.1 > +++ modules/sys_socket 19 Jun 2006 11:00:08 -0000 > @@ -26,6 +26,7 @@ > -rmdir sys 2>/dev/null > > Include: > +#include <sys/types.h> > #include <sys/socket.h> > > License:
