On Wed, 2006-06-21 at 12:03 +0200, Simon Josefsson wrote: > Simon Josefsson <[EMAIL PROTECTED]> writes: > > > Yoann Vandoorselaere <[EMAIL PROTECTED]> writes: > > > >> On Sat, 2006-06-17 at 21:02 +0200, Simon Josefsson wrote: > >>> Hi Yoann! Ok to install this? Gnulib assumes that sys/types.h > >>> exists, and inet_ntop never tested HAVE_SYS_TYPES_H anyway. > >> > >> Hi Simon, > >> > >> Did you make sure that removing the sys/types.h requirement doesn't > >> break the build on some platform, like FreeBSD 4.x ? > > > > Hi! sys/types.h is still included by the source code, what I did was > > to remove the autoconf test for sys/types.h, because the > > HAVE_SYS_TYPES_H CPP symbol wasn't used and isn't needed. > > > > Gnulib assumes that sys/types.h exists on all platforms, so we > > shouldn't test for it. > > Hi Yoann, are you happy with my explanation? Do you see any other > problem with this patch?
Hi Simon, Yes, please go ahead. Regards, -- Yoann Vandoorselaere | Responsable R&D / CTO | PreludeIDS Technologies Tel: +33 (0)8 70 70 21 58 Fax: +33(0)4 78 42 21 58 http://www.prelude-ids.com
