On Tue, 2005-10-25 at 01:31 +0200, Simon Josefsson wrote: > A GnuTLS user reported that inet_ntop did not build on mingw32, so I > took a look at it. The patch below fixes: > > * Add "restrict" keywords, as per POSIX. > > * Don't include sys/socket.h or netinet/in.h, as they didn't appear to > be necessary? The sys/socket.h file was the one causing problems > here (mingw32 doesn't have it). If sys/socket.h and/or netinet/in.h > really is needed on some system, we should add a check for it in > inet_ntop.m4 and only conditionally include it in inet_ntop.h.
[...] > I have not tested this on many platforms yet, so the sys/socket.h and > netinet/in.h issue may turn out to be flawed here. But I intend to > check this soon, fixing this is one of two things blocking GnuTLS > 1.2.9, and I will test it on many platforms before the release. > > Ok to install? Hi Simon, As you point out above, the untested netinet/in.h and sys/socket.h change might lead to compilation warnings/failure on some systems. It would be a good idea to check this specific change on OpenBSD 3.4 for example. Apart from this specific change, I have no problem in having this included. Regards, -- Yoann Vandoorselaere | Responsable R&D / CTO | PreludeIDS Technologies Tel: +33 (0)8 70 70 21 58 Fax: +33(0)4 78 42 21 58 http://www.prelude-ids.com _______________________________________________ bug-gnulib mailing list bug-gnulib@gnu.org http://lists.gnu.org/mailman/listinfo/bug-gnulib
