Michael Albinus <michael.albi...@gmx.de> writes:
>>> ;; Symbolic link to a non-directory.
>>> ...
>>> + "\\(.+-> ?\\)\\(.+\\)" end t))))))
>>
>> Minor nitpick: given the comment for this section (which seems to
>> suggest this only applies to symlinks to non-directories), wouldn't it
>> be "better" to simply have something like below instead for the if-then
>> case? I.e., a separate entry in dired-font-lock-keywords for the
>> failsafe.
>>
>> #+begin_src emacs-lisp
>> ;; Generic face for symbolic links
>> (list dired-re-sym
>> (when (not (connection-local-value dired-check-symlinks))
>> '(".+" (dired-move-to-filename) nil (0 dired-symlink-face))))
>> #+end_src
>>
>> This is essentially what I have in my config today, and seems to behave
>> as expected.
>
> Possible, but I don't see that one version is "better" or "worse" than
> the other.
Understood.
> So I don't see a need to change it.
The comment ";; Symbolic link to a non-directory." should probably be
updated in that case, right? Apologies for the noise, in case I have
misunderstood the patch.
I should be able to test out the patch later this coming week. In case
that would be helpful, please let me know. Thank you for adding this.
--
Suhail
