On 5/24/18 2:29 PM, Eric Blake wrote: > On 05/24/2018 01:18 PM, Chet Ramey wrote: >> On 5/24/18 11:40 AM, gabriele balducci wrote: >>> hi >>> >>> just tried to build/install readline-8.0-alpha and found the following >>> glitch: >> >> Thanks for the report. I think a better fix is to not to attempt to >> install readline.pc if $(pkgconfigdir) is missing. > > Why not? If you are doing an install into DESTDIR for the purpose of > bundling a pre-built binary for a distro, then $(pkgconfigdir) will be > missing, because the ONLY things living in DESTDIR are what the package > itself installs. When DESTDIR is empty, you're right that either > $(pkgconfigdir) is likely to already exist, or that the user is not using > pkg-config; but even that's a risky assumption (when bootstrapping a > system, readline might be installed prior to pkg-config, and we shouldn't > require the user to run 'make install' a second time just to install the > pieces that weren't installed the first time).
Good point about $(DESTDIR). I don't quite buy the bootstrapping argument. -- ``The lyf so short, the craft so long to lerne.'' - Chaucer ``Ars longa, vita brevis'' - Hippocrates Chet Ramey, UTech, CWRU c...@case.edu http://tiswww.cwru.edu/~chet/