On 05/24/2018 01:29 PM, Eric Blake wrote:
On 05/24/2018 01:18 PM, Chet Ramey wrote:
On 5/24/18 11:40 AM, gabriele balducci wrote:
hi
just tried to build/install readline-8.0-alpha and found the following
glitch:
Thanks for the report. I think a better fix is to not to attempt to
install readline.pc if $(pkgconfigdir) is missing.
Why not? If you are doing an install into DESTDIR for the purpose of
bundling a pre-built binary for a distro, then $(pkgconfigdir) will be
missing, because the ONLY things living in DESTDIR are what the package
itself installs. When DESTDIR is empty, you're right that either
$(pkgconfigdir) is likely to already exist, or that the user is not
using pkg-config; but even that's a risky assumption (when bootstrapping
a system, readline might be installed prior to pkg-config, and we
shouldn't require the user to run 'make install' a second time just to
install the pieces that weren't installed the first time).
Or, if you DO want to make it configurable as to whether to install the
.pc file, then make it a './configure --enable-pkg-config' or some such
flag at configure time, so the user can explicitly decide up front (with
a sane default if they don't mention anything) whether 'make install'
should attempt to install the .pc file, rather than making a magic
decision based on whether a $(pkgconfigdir) directory already exists.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
