I agree that the "non-active documents" part would be a fraction of the usage you stated, and hence likely very small.
Having a Finch kill-switch handy and carefully monitoring the rollout sound like a reasonable approach to me. On Wed, Oct 30, 2024 at 8:06 PM Mason Freed <mas...@chromium.org> wrote: > On Wed, Oct 30, 2024 at 3:47 AM Yoav Weiss (@Shopify) < > yoavwe...@chromium.org> wrote: > >> What are the current usecounters for `showPopover()` and `showModal()`? >> Have we looked at current usage to have enough confidence that it's >> currently being try/catched? >> > > Yeah, good questions. So there aren't use counters for `showPopover()`, > but the overall use counter for popovers is 0.4% currently > <https://chromestatus.com/metrics/feature/timeline/popularity/4191>. And > the `showModal()` use counter is at 0.08% > <https://chromestatus.com/metrics/feature/timeline/popularity/3726>. The > important bit is that I would expect that a vanishingly-small percentage of > these uses falls into the bucket affected by this change: calling those > methods while the document is inactive. I don't think I could find that > type of usage via HTTP Archive, so it'd have to be via a specific use > counter for that case. Instead, my plan has been to monitor carefully, and > Finch this change back off in the case that there is real usage of this > case. LMK what you think. > > Thanks, > Mason > > > >> On Tue, Oct 29, 2024 at 4:50 PM Mason Freed <mas...@chromium.org> wrote: >> >>> Contact emailsmas...@chromium.org >>> >>> Specificationhttps://github.com/whatwg/html/pull/10705 >>> >>> Summary >>> >>> This is a corner case change that hopefully does not impact developers. >>> Previously calling `showPopover()` or `showModal()` on a popover or dialog >>> that resides within an inactive document would silently fail. I.e. no >>> exception would be thrown, but since the document is inactive, no popover >>> or dialog would be shown. As of the >>> https://github.com/whatwg/html/pull/10705 spec PR, these situations now >>> throw InvalidStateError. >>> >>> >>> Blink componentBlink>DOM >>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EDOM> >>> >>> TAG reviewNone >>> >>> TAG review statusNot applicable >>> >>> Risks >>> >>> >>> Interoperability and Compatibility >>> >>> There is a *very* slight compat risk, if developers are counting on >>> these operations (showPopover/showModal in inactive document) not throwing >>> exceptions. But there are no known use cases for that, so the risk should >>> be minimal. >>> >>> >>> *Gecko*: No signal >>> >>> *WebKit*: No signal >>> >>> *Web developers*: No signals >>> >>> *Other signals*: >>> >>> WebView application risks >>> >>> Does this intent deprecate or change behavior of existing APIs, such >>> that it has potentially high risk for Android WebView-based applications? >>> >>> None >>> >>> >>> Debuggability >>> >>> None >>> >>> >>> Will this feature be supported on all six Blink platforms (Windows, Mac, >>> Linux, ChromeOS, Android, and Android WebView)?Yes >>> >>> Is this feature fully tested by web-platform-tests >>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>> ?Yes >>> >>> https://chromium-review.googlesource.com/c/chromium/src/+/5943740 >>> >>> >>> Flag name on chrome://flagsTopLayerInactiveDocumentExceptions >>> >>> Finch feature nameTopLayerInactiveDocumentExceptions >>> >>> Requires code in //chrome?False >>> >>> Tracking bughttps://crbug.com/373684393 >>> >>> Estimated milestones >>> Shipping on desktop 132 >>> DevTrial on desktop 132 >>> Shipping on Android 132 >>> DevTrial on Android 132 >>> Shipping on WebView 132 >>> >>> Anticipated spec changes >>> >>> Open questions about a feature may be a source of future web compat or >>> interop issues. Please list open issues (e.g. links to known github issues >>> in the project for the feature specification) whose resolution may >>> introduce web compat/interop risk (e.g., changing to naming or structure of >>> the API in a non-backward-compatible way). >>> None >>> >>> Link to entry on the Chrome Platform Status >>> https://chromestatus.com/feature/6352111728852992?gate=5229499854356480 >>> >>> This intent message was generated by Chrome Platform Status >>> <https://chromestatus.com/>. >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to blink-dev+unsubscr...@chromium.org. >>> To view this discussion visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM%3DNeDgP3vEKfHhwf7WTaKn1LWK0GF3JzCq7yXrn_Axwx9d0aQ%40mail.gmail.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM%3DNeDgP3vEKfHhwf7WTaKn1LWK0GF3JzCq7yXrn_Axwx9d0aQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohSLztsyim3CvL0i0zF-eqZA%2B4WqYTPvCxjPLSqcdU1zsEA%40mail.gmail.com.
