LGTM3 On Friday, March 22, 2024 at 8:01:46 PM UTC+1 Chris Harrelson wrote:
> LGTM2 > > On Fri, Mar 22, 2024 at 11:46 AM Mike Taylor <miketa...@chromium.org> > wrote: > >> LGTM1 >> On 3/20/24 2:27 PM, Vladimir Levin wrote: >> >> Contact emails vmp...@chromium.org, nrosent...@chromium.org >> >> Explainer >> https://github.com/vmpstr/web-proposals/blob/main/explainers/view-transition-classes.md >> >> >> Specification >> https://drafts.csswg.org/css-view-transitions-2/#view-transition-class-prop >> >> Summary >> >> This feature introduces a new CSS property view-transition-class which >> allows the developer to specify one or more view transition classes. The >> developer can then select the ViewTransition pseudo elements using these >> classes (e.g. ::view-transition-group(*.class)). This is an extension to >> the ViewTransition API that simplifies styling of view transition pseudo >> elements in a similar way that CSS classes simplify styling of regular DOM >> elements. >> >> TAG review https://github.com/w3ctag/design-reviews/issues/938 >> >> TAG review status Pending >> >> Risks >> >> >> Interoperability and Compatibility >> >> The risk of interoperability is small, since this is a feature that has >> been introduced and discussed in the CSSWG with possible input from all of >> the major browser vendors. It is a new feature that builds on the view >> transition feature, but it's a fairly small delta and a qualify of life >> improvement for developers. This feature is fully backward compatible with >> previously valid syntax. >> >> >> *Gecko*: No signal ( >> https://github.com/mozilla/standards-positions/issues/988) >> >> *WebKit*: No signal ( >> https://github.com/WebKit/standards-positions/issues/321) >> >> *Web developers*: Positive ( >> https://twitter.com/mhartington/status/1731670490341642649) (citation is >> one example) >> >> >> Ergonomics >> >> This feature is an ergonomic improvement to the view transitions feature. >> >> >> Activation >> >> There are no activation risks >> >> >> Security >> >> There are no known security risks >> >> >> WebView application risks >> >> Does this intent deprecate or change behavior of existing APIs, such that >> it has potentially high risk for Android WebView-based applications? >> >> None >> >> >> Debuggability >> >> This feature is debuggable via DevTools similar other css properties >> >> >> Will this feature be supported on all six Blink platforms (Windows, Mac, >> Linux, ChromeOS, Android, and Android WebView)? Yes >> >> Is this feature fully tested by web-platform-tests >> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >> ? Yes >> >> >> https://wpt.fyi/results/css/css-view-transitions?label=master&label=experimental&aligned&q=pseudo-with-classes >> >> <https://drafts.csswg.org/css-view-transitions-2/#view-transition-class-prop> >> >> >> Note that the tests are not passing because this flag is currently >> disabled. >> >> >> Flag name on chrome://flags None >> >> Finch feature name CSSViewTransitionClass >> >> Requires code in //chrome? False >> >> Tracking bug >> https://bugs.chromium.org/p/chromium/issues/detail?id=1519997 >> >> Estimated milestones >> Shipping on desktop 125 >> Shipping on Android 125 >> Shipping on WebView 125 >> >> Anticipated spec changes >> >> Open questions about a feature may be a source of future web compat or >> interop issues. Please list open issues (e.g. links to known github issues >> in the project for the feature specification) whose resolution may >> introduce web compat/interop risk (e.g., changing to naming or structure of >> the API in a non-backward-compatible way). >> None >> >> Link to entry on the Chrome Platform Status >> https://chromestatus.com/feature/5064894363992064 >> >> Links to previous Intent discussions Intent to prototype: >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADsXd2O9SoVce7bGHcDMW36pCBt4VAiXzHZa9yoFk4omOp%2BHKg%40mail.gmail.com >> >> This intent message was generated by Chrome Platform Status >> <https://chromestatus.com/>. >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADsXd2Mj4qqpZjZwuLgan0YDR90BXDy%3DnzHU0bZcy4GuppmYRQ%40mail.gmail.com >> >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADsXd2Mj4qqpZjZwuLgan0YDR90BXDy%3DnzHU0bZcy4GuppmYRQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> > To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/206dacb7-20d8-4782-9ed9-fceaa18ef039%40chromium.org >> >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/206dacb7-20d8-4782-9ed9-fceaa18ef039%40chromium.org?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/8aaca901-002d-4346-88de-4e18543ae52cn%40chromium.org.