LGTM3

/Daniel

On 2024-03-13 16:19, Yoav Weiss (@Shopify) wrote:
LGTM2

On Wed, Mar 13, 2024 at 10:59 AM Noam Rosenthal <nrosent...@chromium.org> wrote:



    On Wed, Mar 13, 2024 at 12:36 PM Yoav Weiss (@Shopify)
    <yoavwe...@chromium.org> wrote:



        On Monday, March 11, 2024 at 6:36:07 AM UTC-4 Noam Rosenthal
        wrote:

            I've run a rough HTTP archive query on it, testing all
            HTTP responses last month (666 million):
            getComputedStyle with an argument that doesn't begin with
            "::" is called in 0.45% of pages, out of which 55% is
            ":before", 28% is after, and the vast majority of the rest
            are invalid pseudo-element names (e.g. "height" or
            "display").
            There were extremely rare cases that would be affected:
            getComputedStyle(element, ":placeholder") or
            getComputedStyle(element, ":marker"), about 0.00001% of
            requests (34 out of 666 million).

        Is this considering all requests? What's the %age when only
        looking at HTML and CSS responses? (or on pages)


    I refined the query a bit and use January dataset. So this will
    potentially affect 89 pages out of 17M (226 responses of 420M). So
    one in every 200,000 pages:
    Total Pages         17,399,427
    Total URLs  420,144,799
    Potentially affected Pages  89
    Potentially affected URLs   226
    % Affected Pages    0.0005%
    % affected URLs     0.0001%


    I'm still running the refinement to only use HTML/JS responses
    (this is not CSS) but I'm not sure it will tell us something new.


Pages %age seems sufficiently small to give confidence here. Thanks!!
--
You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohSLTt%3DMgVzGw%2Beij8Hsga4%3DTaqDHcsDKwUH3H0khN0acSw%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohSLTt%3DMgVzGw%2Beij8Hsga4%3DTaqDHcsDKwUH3H0khN0acSw%40mail.gmail.com?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/97c5bd80-6b1a-4d8a-a129-facfe36d4d26%40gmail.com.

Reply via email to