On Tue, Jul 10, 2018 at 5:10 AM, matejcik <jan.mate...@satoshilabs.com> wrote: > On 6.7.2018 00:06, Pieter Wuille wrote:> The only case where "malicious" > conflicting values can occur is when >> one of the Signers produces an invalid signature, or modifies any of >> the other fields already present in the PSBT for consumption by >> others. If this were an issue, it would be an issue regardless of the >> Combiner's operation, as in topology A no Combiner is even present. >> This is generally true I think - Combiners can always be replaced with >> just a different (and possibly less parallel) topology of data flow. > > This is an interesting thesis, and also an unspoken assumption ISTM. It > seems worth adding something like this to the spec: > """ > In general, the result of Combiner combining two PSBTs from independent > participants A and B should be functionally equivalent to a result > obtained from processing the original PSBT by A and then B in a sequence. > or, for participants performing fA(psbt) and fB(psbt): > Combine(fA(psbt), fB(psbt)) == fA(fB(psbt)) == fB(fA(psbt)) > """
Adding that sounds like a good idea, indeed. >> The bottom line is that a Combiner which picks arbitrarily in case of >> conflicts will never end up with something worse than what you already >> need to deal with. If you disregard the case of invalid fields >> (because the result will just be an invalid transaction), then any >> choice the Combiner makes is fine, because all the values it can pick >> from are valid. > > This sounds reasonable and IMHO it would be good to have a summary of > this argument in the Rationale section. Sounds good. >> If you're worried about attack surface, I don't believe rejecting >> invalid fields ever matters. An attacker can always drop the fields >> you don't understand before giving you the PSBT, making your behavior >> identical to one where you'd have ignore those fields in the first >> place. > > I'm reluctant to sign an input with unknown data, on the premise that there > could be *anything* in that data But the point is: you are not signing an input with unknown data. You are signing your own interpretation (since you compute the sighash yourself), which doesn't include what you don't understand. If that interpretation doesn't match reality, the signature is at worst useless. Who cares that someone added information about a transaction that doesn't affect what you sign? > We are most likely to implement the "do not sign with unknown fields" > rule in any case (technically a whitelist of "known OK" field types), > and resolve potential problems as they arise. I raised this point mainly > because I think discussing this explicitly in the spec is beneficial: a > distinction between mandatory and optional fields is one way, mentioning > or prescribing possible signing strategies is another. I don't think that's a particularly useful policy, but certainly Signers are allowed to implement any policy they like about what they accept in signing. Cheers, -- Pieter _______________________________________________ bitcoin-dev mailing list bitcoin-dev@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev
