On Tuesday, May 21, 2002, at 06:43 , David Gray wrote:

>>      if (!($icname =~ /^[$allow]+$/)) {
[..]
>  if($icname !~ /^[$allow]+$/) {
[..]
>  }

personally I would have done the

        unless ($icname =~ /^[$allow]+$/) {
                # do ourstuff since $icname is not allowed
                ....
        }

but that is more because when reading perl code I
like the 'unlessNess' tricks... and realistically
would probably have done

        whineAbout($icname, $allow) unless ($icname =~ /^[$allow]+$/) ;

so that I would need maintain only the function 'whineAbout....'
as a part of the generalized validation suite...

but in this case I thought it was simpler to focus in on
what David was directly looking at - and we'd cover this
distance later on in the game....

ciao
drieux

---

ps: liked the

        my @invalid = ();
        push @invalid, $1
      while $icname =~ m/([^$allow])/g;

that I think I will steal this for elsewhere


-- 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to