I reserved comment on the substance of the patch until it was in a form that was easily reviewed.
But now that you bring it up, :-) yes configure should not be modifying the source files directly that is exactly what config.h is for. However when you are adding a new feature, you don't want to break the existing behaviour if at all possible. I've already implemented part of this in version 1.39.27. But I made it look in the standard directory only if it didn't exist in the current directory. I didn't want to change configure at this late stage so it just defaults to /etc/bacula on Unix and the "All Users\Application Data\Bacula" directory on Windows. I didn't think there were a large number of users using alternate directories for their configuration files. Since this is the second time in a week someone has requested this I'll reconsider it. -----Original Message----- From: Martin Simmons [mailto:[EMAIL PROTECTED] Sent: Monday, November 06, 2006 12:03 PM To: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: Re: [Bacula-devel] info about "CONFIG_FILE" >>>>> On Mon, 06 Nov 2006 19:05:22 +0100, Christian said: > > Hi Robert, > > all files that includes "CONFIG_FILE" are renamed to [filename].in, so > it is impossible to show only changes. > I thought all files that are modified during configure should have > extension ".in" > > Example: > diff -ruN bacula-1.38.11-orig/src/console/console.c > bacula-1.38.11/src/console/console.c > --- bacula-1.38.11-orig/src/console/console.c 2005-08-10 > 16:35:19.000000000 +0000 > +++ bacula-1.38.11/src/console/console.c 2006-11-01 22:33:05.000000000 > +0000 > @@ -94,7 +94,7 @@ > static int sleepcmd(FILE *input, BSOCK *UA_sock); > > > -#define CONFIG_FILE "./bconsole.conf" /* default configuration file */ > +#define CONFIG_FILE "@sysconfidir@/bconsole.conf" /* default > configuration file */ > > static void usage() > { I think the defaults for these should be defined via one generated header file (maybe config.h?). I.e. files like console.c should contain #define CONFIG_FILE DEFAULT_CONFIG_DIR"/bconsole.conf" and the generated header file should define DEFAULT_CONFIG_DIR. __Martin > Robert Nelson schrieb: > > There are a number of problems with your patch. When you are submitting > > patches you should use the current CVS version of the source. > > > > There appears to be a mismatch in line endings between the original > > reference and your modified version. The result is that diff thinks the > > whole file has changed. This makes it next to impossible to see what you've > > changed. > > > > Before you submit a patch you should review it to make sure that it only > > lists the changes you made. > > > > -----Original Message----- > > From: [EMAIL PROTECTED] > > [mailto:[EMAIL PROTECTED] On Behalf Of Christian > > Sent: Monday, November 06, 2006 7:18 AM > > To: [Bacula-devel] > > Subject: [Bacula-devel] info about "CONFIG_FILE" > > > > Hi, > > > > just wondering why bacula-apps does not look for needed "CONFIG_FILE" in > > "sysconfdir" first. > > So I applied a patch which will set correct path to "CONFIG_FILE" when > > building bacula from source. > > > > Best regards > > > > Christian > > > > > > > > > > ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Bacula-users mailing list Bacula-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bacula-users
