On 16 Feb 2006 at 17:54, Rudolf Cejka wrote: > Dan Langille wrote (2006/02/16): > > One suggested change to the script: > > -# Changer Command = "path-to-this-script/chio-changer" %c %o %S %a %d > > +# Changer Command = "path-to-this-script/chio-changer %c %o %S %a %d" > > I think the quote needs to be moved to where shown. > > I think too and I have sent my chio-changer script to Kern with > Changer Command = "path-to-this-script/chio-changer %c %o %S %a %d", > but Kern changed it to variant with quotes just around chio-changer > I do not why. > > > If you agree, I'll commit soon. > > Yes, I do agree, but before we should talk with Kern about it. Fast > grep command says that there are 7 possible files with the same problem > and until we talk with Kern, it is possible that somebody will want to > return them to their current form.
The documention is correct, the examples in the files are wrong: http://www.bacula.org/dev-manual/Storage_Daemon_Configuratio.html > examples/autochangers/chio-changer > examples/autochangers/locking-mtx-changer > examples/autochangers/mtx-changer.Adic-Scalar-24 > examples/autochangers/multiple-drive-changer.txt > examples/autochangers/rc-chio-changer > examples/autochangers/solaris-mtx-changer > scripts/mtx-changer.in Sun-desktop-20Gb-4mm-autoloader is right. mtx-changer.Adic-Scalar-100 is right. multiple-drive-changer.txt is right. The ones that are wrong, are comments. I think we're fine making this change without consulting Kern. more information: With quotes like this: Changer Command = "/home/dan/rc-chio-changer" %c %o %S %a %d btape gives this: # btape -c /usr/local/etc/bacula-sd.conf /dev/nsa0 Tape block granularity is 1024 bytes. btape: butil.c:269 Using device: "/dev/nsa0" for writing. 16-Feb 11:59 btape: 3301 Issuing autochanger "loaded drive 0" command. 16-Feb 11:59 btape: 3991 Bad autochanger "loaded drive 0" command: ERR=Child exited with code 1. 16-Feb 11:59 btape: 3301 Issuing autochanger "loaded drive 0" command. 16-Feb 11:59 btape: 3991 Bad autochanger "loaded drive 0" command: ERR=Child exited with code 1. btape: btape.c:338 open device "DLT" (/dev/nsa0): OK * With the quotes as they are, you get empty paramters passed. I verified this by adding this to the script: logger "${PROGNAME} '$1' '$2' '$3' '$4' '$5'" This adds this to /var/log/messages: Feb 16 11:33:03 ngaio dan: rc-chio-changer '' '' '' '' '' When I use this: Changer Command = "/home/dan/rc-chio-changer %c %o %S %a %d" I get this instead: Feb 16 11:33:39 ngaio dan: rc-chio-changer '/dev/ch0' 'loaded' '0' '/dev/nsa0' '0' And btape works: # btape -c /usr/local/etc/bacula-sd.conf /dev/nsa0 Tape block granularity is 1024 bytes. btape: butil.c:269 Using device: "/dev/nsa0" for writing. 16-Feb 12:00 btape: 3301 Issuing autochanger "loaded drive 0" command. 16-Feb 12:00 btape: 3302 Autochanger "loaded drive 0", result is Slot 1. 16-Feb 12:00 btape: 3301 Issuing autochanger "loaded drive 0" command. 16-Feb 12:00 btape: 3302 Autochanger "loaded drive 0", result is Slot 1. btape: btape.c:338 open device "DLT" (/dev/nsa0): OK * Any hesistations now? -- Dan Langille : Software Developer looking for work my resume: http://www.freebsddiary.org/dan_langille.php ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642 _______________________________________________ Bacula-users mailing list Bacula-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bacula-users
