| OK, how about this one?

Sorry, I don't mean to be pain, but I still have some comments :) Do
the other people consider I am being painful? (Real question)

Still, my comment would be that

|  #ifdef __cplusplus
| -extern "C" { void *malloc(unsigned); }
| +# ifdef HAVE_STDLIB_H
| +#  include <stdlib.h>
| +# endif
| +# ifdef HAVE_UNISTD_H
| +#  include <unistd.h>
| +# endif
| +# ifdef HAVE_SYS_STAT_H
| +#  include <sys/stat.h>
| +# endif
|  #else
| -char *malloc();
| +char *malloc ();
|  #endif

I would not condition the includes by __cplusplus, since the C
compiler will be happy too to have them.  What do other people think?
Also, ifdef and ifndef are banished from Autoconf, use only #if and
#if !.

How about

#if HAVE_STDLIB_H
# include <stdlib.h>
#else
char *malloc ();
#endif
#if HAVE_UNISTD_H
# include <unistd.h>
#endif
#if HAVE_SYS_STAT_H
# include <sys/stat.h>
#endif

or maybe shall we check that malloc is declared?

        Akim

Reply via email to