>>>>> "Olly" == Olly Betts <[EMAIL PROTECTED]> writes:

Olly> Only one potential down side I can see - is it known that this
Olly> trick works as expected everywhere?

I don't think we've tried it anywhere, but I imagine it is pretty
safe.  There's another trick along similar lines: you can try to make
a static array where the dimension is possibly a negative number.

Olly> If this patch doesn't get applied, note that it corrects an obscure
Olly> problem with the existing AC_C_CHAR_UNSIGNED: this won't work as
Olly> intended on platforms where CHAR_BIT >= 9 bits (very uncommon these
Olly> days, but allowed by ANSI IIRC).  There it will always report that
Olly> char is unsigned since 255 will be a valid value for a signed char.

Nice.
Your patch has a problem if sizeof(int)==sizeof(char).
Still, I prefer your approach to the current approach.

This patch is ok with me.

Tom

Reply via email to