> Date: Mon, 10 Jan 2022 18:35:05 +0100 > From: Patrick Wildt <patr...@blueri.se> > > Am Mon, Jan 10, 2022 at 07:42:12PM +0900 schrieb SASANO Takayoshi: > > Hi, > > > > To change AXP80x into RSB mode, put 0x7c value to register 0x3e. > > The value defined RSB_DMCR_DEVICE_MODE_DATA in sxirsb.c works > > 0x7e to the register. It needs to be fixed. > > > > At least my Allwinner H616 with AXP305 works good with fixed value. > > Yeah, that definitely seems like a bug. Unless anyone reports a > regression, that's OK with me and definitely the correct fix.
A64 + AXP803 works fine with this diff on the pinebook, and this matches the Linux code. ok kettenis@ > I wonder if that fixes the machine from Pinephone thread? Me too. > > By the way, I have a question > > Does Allwinner-A64 with AXP803 boards works with 0x7e value? > > > > -- > > SASANO Takayoshi (JG1UAA) <u...@mx5.nisiq.net> > > > > Index: sxirsb.c > > =================================================================== > > RCS file: /cvs/src/sys/dev/fdt/sxirsb.c,v > > retrieving revision 1.4 > > diff -u -p -r1.4 sxirsb.c > > --- sxirsb.c 24 Oct 2021 17:52:27 -0000 1.4 > > +++ sxirsb.c 10 Jan 2022 10:33:55 -0000 > > @@ -45,7 +45,7 @@ > > #define RSB_DATA 0x001c > > #define RSB_DMCR 0x0028 > > #define RSB_DMCR_DEVICE_MODE_START (1U << 31) > > -#define RSB_DMCR_DEVICE_MODE_DATA 0x7e3e00 > > +#define RSB_DMCR_DEVICE_MODE_DATA 0x7c3e00 > > #define RSB_CMD 0x002c > > #define RSB_DAR 0x0030 > > > >
