> From: "Stephen Graf" <s_g...@telus.net> > Date: Tue, 12 Dec 2017 11:30:59 -0800 > > I tested the new code on my orange pi one (H3) and it works for the most > part. The communications works but the yellow LED that indicates line speed > (I think) does not light up. I compared the code to my working version and > put back the following, which makes the LED work. > > # diff -u if_dwxe_new.c if_dwxe.c > --- if_dwxe_new.c Tue Dec 12 10:53:42 2017 > +++ if_dwxe.c Tue Dec 12 10:57:04 2017 > @@ -475,9 +475,8 @@ > syscon |= SYSCON_H3_EPHY_LED_POL; > else > syscon &= ~SYSCON_H3_EPHY_LED_POL; > - syscon &= ~SYSCON_H3_EPHY_ADDR_MASK; > + syscon &= ~(SYSCON_H3_EPHY_ADDR_MASK << > SYSCON_H3_EPHY_ADDR_SHIFT); > syscon |= (sc->sc_phyloc << SYSCON_H3_EPHY_ADDR_SHIFT); > - return; > } > free(phy_mode, M_TEMP, len);
Hi Stephen, I removed the stray return, but the SYSCON_H3_EPHY_ADDR_MASK bit doesn't make sense. Can you check whether it works with just the return removed? Thanks, Mark
