Re: [PATCH] drm/amd/amdkfd: Evict all queues even HWS remove queue failed

[Zha, YiFan(Even)]

[AMD Official Use Only - AMD Internal Distribution Only]

Hi Felix,

Thanks. Patch v2 is submitted. It should make sure error returned even if 
remove_queue_mes is success.

Could you pleas help to review it again?


Thanks.



Best regard,

Yifan Zha



________________________________
From: Kuehling, Felix <felix.kuehl...@amd.com>
Sent: Thursday, March 6, 2025 8:23 AM
To: Zha, YiFan(Even) <yifan....@amd.com>; amd-gfx@lists.freedesktop.org 
<amd-gfx@lists.freedesktop.org>; Deucher, Alexander 
<alexander.deuc...@amd.com>; Zhang, Hawking <hawking.zh...@amd.com>
Cc: Chang, HaiJun <haijun.ch...@amd.com>; Chen, Horace <horace.c...@amd.com>; 
Yin, ZhenGuo (Chris) <zhenguo....@amd.com>
Subject: Re: [PATCH] drm/amd/amdkfd: Evict all queues even HWS remove queue 
failed


On 2025-03-05 00:42, Yifan Zha wrote:
> [Why]
> If reset is detected and kfd need to evict working queues, HWS moving queue 
> will be failed.
> Then remaining queues are not evicted and in active state.
>
> After reset done, kfd uses HWS to termination remaining activated queues but 
> HWS is resetted.
> So remove queue will be failed again.
>
> [How]
> Keep removing all queues even if HWS returns failed.
> It will not affect cpsch as it checks reset_domain->sem.
>
> Signed-off-by: Yifan Zha <yifan....@amd.com>
> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c 
> b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> index f3f2fd6ee65c..b213a845bd5b 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> @@ -1223,7 +1223,6 @@ static int evict_process_queues_cpsch(struct 
> device_queue_manager *dqm,
>                        if (retval) {
>                                dev_err(dev, "Failed to evict queue %d\n",
>                                        q->properties.queue_id);
> -                             goto out;

Is every subsequent call to remove_queue_mes guaranteed to also return
an error? If not, you need a way to make sure an error is returned if
any queue failed to be removed even if the last queue succeeded.

Regards,
   Felix


>                        }
>                }
>        }