----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129192/#review102664 -----------------------------------------------------------
Ship it! Matthias wrote: > Pro: Works well on Wayland and allows using D-Bus activation. That is more > important than "just" being standard compliant. Let's merge this to master (and thus kf5) then! - Matěj Laitl On Říj. 16, 2016, 4:12 odp., Luigi Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129192/ > ----------------------------------------------------------- > > (Updated Říj. 16, 2016, 4:12 odp.) > > > Review request for Amarok and Matthias Klumpp. > > > Repository: amarok > > > Description > ------- > > - add the organization namespace to the desktop and then appdata files, > according the specification; > - use the new directory for metadata (metainfo) files. > > > Diffs > ----- > > src/CMakeLists.txt 327ec10 > src/amarok.appdata.xml c580fd5 > src/amarok.desktop > src/amarok_containers.desktop > src/dbus/mpris2/MediaPlayer2.cpp a1d1bda > > Diff: https://git.reviewboard.kde.org/r/129192/diff/ > > > Testing > ------- > > Compiles, the files are installed in the expected places. > > > Thanks, > > Luigi Toscano > >
