> On Oct. 16, 2016, 9:12 p.m., Matthias Klumpp wrote: > > Please rename the .desktop files too, the name of the .desktop file and the > > value of the `<id/>` tag must match for this to work. > > The DBus activation and Wayland window mapping will also only work with the > > renamed .desktop files. > > Matthias Klumpp wrote: > Ah, I see it's renamed in the cmake install section - a bit > unconventional, but it will work. > > Luigi Toscano wrote: > The desktop files for Type=Application are renamed in the patch. The > first question was about desktop files which represent Service. If I read the > specification correctly, the requirement for the namespace is only for > desktop files for applications, is it correct? > > The second question is: how much does the change break stuff like > customer-set file applications and/or shortcuts in panels?
You are correct, the requirement counts only for type=desktop-application components. Renming the .desktop file will make panel shortcuts vanish, so users will need to re-add them, I'm afraid. - Matthias ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129192/#review100051 ----------------------------------------------------------- On Oct. 16, 2016, 2:12 p.m., Luigi Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129192/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2016, 2:12 p.m.) > > > Review request for Amarok and Matthias Klumpp. > > > Repository: amarok > > > Description > ------- > > - add the organization namespace to the desktop and then appdata files, > according the specification; > - use the new directory for metadata (metainfo) files. > > > Diffs > ----- > > src/CMakeLists.txt 327ec10 > src/amarok.appdata.xml c580fd5 > src/amarok.desktop > src/amarok_containers.desktop > src/dbus/mpris2/MediaPlayer2.cpp a1d1bda > > Diff: https://git.reviewboard.kde.org/r/129192/diff/ > > > Testing > ------- > > Compiles, the files are installed in the expected places. > > > Thanks, > > Luigi Toscano > >
