----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122797/#review102538 -----------------------------------------------------------
Ship it! Looks good to me, builds, and runs as expected. The beta has been out since quite some time so I'll push this. - Heiko Becker On Feb. 17, 2017, 8:46 nachm., Giuseppe Silletti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122797/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2017, 8:46 nachm.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > ------- > > Before to fix this bug, the gpodder plugin had problems with saving username > and password in plain text. > > There were two problems: > > 1) A useless space for the variable m_ignoreWallet was saved in the config > file > 2) The saving of the credential in plain text where made in the wrong way. > Now it is called the function askAboutMissingKWallet(), that make the use see > a dialog windows where is asked to save the credential in plain text. > Credential are now saved in the textDialogYes slot. > > > Diffs > ----- > > src/services/gpodder/GpodderServiceConfig.cpp 9098d59 > > Diff: https://git.reviewboard.kde.org/r/122797/diff/ > > > Testing > ------- > > It simply works now > > > Thanks, > > Giuseppe Silletti > >
