> On March 3, 2015, 9:36 p.m., Stefan Derkits wrote: > > src/services/gpodder/GpodderServiceConfig.cpp, line 233 > > <https://git.reviewboard.kde.org/r/122797/diff/1/?file=352893#file352893line233> > > > > This slot is called when the user clicks on no in the dialog asking if > > the credentials should be stored in plaintext. This means that the > > credentials shouldn't be saved when this slot is called. > > Giuseppe Silletti wrote: > I wrote those lines to reset the credential in the config file. > > Giuseppe Silletti wrote: > I don't have commit access, could someone push it? > > Myriam Schweingruber wrote: > as explained in the amarok-devel mailing list, we are currently in > release freeze. I will push it once the 2.9 beta is out. And really, 2 weeks > wait is not long, one has to be patient in Free Software, we all have a full > day job which sadly is not Amarok ...
Myriam was this ever pushed? - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122797/#review76967 ----------------------------------------------------------- On March 3, 2015, 9:14 p.m., Giuseppe Silletti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122797/ > ----------------------------------------------------------- > > (Updated March 3, 2015, 9:14 p.m.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > ------- > > Before to fix this bug, the gpodder plugin had problems with saving username > and password in plain text. > > There were two problems: > > 1) A useless space for the variable m_ignoreWallet was saved in the config > file > 2) The saving of the credential in plain text where made in the wrong way. > Now it is called the function askAboutMissingKWallet(), that make the use see > a dialog windows where is asked to save the credential in plain text. > Credential are now saved in the textDialogYes slot. > > > Diffs > ----- > > src/services/gpodder/GpodderServiceConfig.cpp 9098d59 > > Diff: https://git.reviewboard.kde.org/r/122797/diff/ > > > Testing > ------- > > It simply works now > > > Thanks, > > Giuseppe Silletti > >
