----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116641/ -----------------------------------------------------------
(Updated Feb. 4, 2017, 10:35 a.m.) Status ------ This change has been marked as submitted. Review request for Amarok. Changes ------- Submitted with commit 2a8cb3785e50ccb0d551442e3133ac1cc6c2e8f7 by Albert Astals Cid on behalf of Yash Ladia to branch master. Bugs: 302299 https://bugs.kde.org/show_bug.cgi?id=302299 Repository: amarok Description ------- The bug was occuring since 'userAutoScrollOffset' and 'oldSliderPosition' were being reset when track metadata was changed. This should not happen. I split the function: 'void _trackDataChanged( Meta::TrackPtr )' into 'void _trackChanged( Meta::TrackPtr )' and 'void _trackMetadataChanged( Meta::TrackPtr )' Diffs ----- src/context/applets/lyrics/LyricsApplet.h 20c71d8 src/context/applets/lyrics/LyricsApplet.cpp 829a166 Diff: https://git.reviewboard.kde.org/r/116641/diff/ Testing ------- Builds and installs. Expected results are obtained during testing. Thanks, yash ladia