> On March 6, 2014, 10:04 p.m., Myriam Schweingruber wrote: > > Are you sure that function is correct? There is a huge different between > > changing metadata for a track and actually changing the track....
The earlier code (_trackDataChanged) updated the lyrics (name, text and position of scroll bar) both when track Metadata was changed and when the track was changed. Both the cases needed to be handled a little differently. Any metadata change from anywhere (not only the "Current Playing" context) was resulting in the advancing of the lyrics scroll-bar. Now, I have created two functions that handle both cases. - yash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116641/#review52306 ----------------------------------------------------------- On March 6, 2014, 10:52 p.m., yash ladia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116641/ > ----------------------------------------------------------- > > (Updated March 6, 2014, 10:52 p.m.) > > > Review request for Amarok. > > > Bugs: 302299 > https://bugs.kde.org/show_bug.cgi?id=302299 > > > Repository: amarok > > > Description > ------- > > The bug was occuring since 'userAutoScrollOffset' and 'oldSliderPosition' > were being reset when track metadata was changed. This should not happen. > > Also, > I corrected the function name: void _trackDataChanged( Meta::TrackPtr ) -> > void _trackChanged( Meta::TrackPtr ) > > > Diffs > ----- > > src/context/applets/lyrics/LyricsApplet.h 20c71d8 > src/context/applets/lyrics/LyricsApplet.cpp 829a166 > > Diff: https://git.reviewboard.kde.org/r/116641/diff/ > > > Testing > ------- > > Builds and installs. > Expected results are obtained during testing. > > > Thanks, > > yash ladia > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
