> On Июнь 20, 2016, 10:42 п.п., Olivier Churlaud wrote: > > Ship It! > > Olivier Churlaud wrote: > It should work with new version: it's a must. If people complain about > older version being broken, then we can see. But archlinux won't be able to > ship Amarok without this fix.
Yes, and will break build for older version, awesome! You don't need to touch code for older version of ffmpeg. The only thing you need is to add one more conditional compillation section for a newer version of library. And mb drop some older versions. - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126682/#review96762 ----------------------------------------------------------- On Янв. 9, 2016, 6:24 д.п., Diane Trout wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126682/ > ----------------------------------------------------------- > > (Updated Янв. 9, 2016, 6:24 д.п.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > ------- > > See API change documentation: > https://anonscm.debian.org/cgit/collab-maint/ffmpeg.git/tree/doc/APIchanges > https://wiki.libav.org/Migration/12 > > > Diffs > ----- > > src/musicbrainz/MusicDNSAudioDecoder.cpp > 6216e5ce26cc3461b89aea560943ad7a79101af9 > > Diff: https://git.reviewboard.kde.org/r/126682/diff/ > > > Testing > ------- > > I installed the patch on the debian 2.8.0 branch and it build successfully. I > then tried to trigger the affected code, however it crashed because of > https://bugs.kde.org/show_bug.cgi?id=328359 > > > Thanks, > > Diane Trout > >
