----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126682/#review90866 -----------------------------------------------------------
Hi. As you can see there is more than one version of decoder. I had to add separate code blocks for different versions of ffmpeg because of weak backward capability from ffmpeg side (call of old API methods caused crushes while It sill compiled well). So I think that It would be better to add one more conditional compilation section for new version (version range) of ffmpeg. But if you pretty sure that your version will compile and work with ffmpeg 0.11 It's ok to keep It like this. Btw probably It's time to drop support of antiant versions like 0.7 and 0.8. - Sergey Ivanov On Янв. 9, 2016, 6:24 д.п., Diane Trout wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126682/ > ----------------------------------------------------------- > > (Updated Янв. 9, 2016, 6:24 д.п.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > ------- > > See API change documentation: > https://anonscm.debian.org/cgit/collab-maint/ffmpeg.git/tree/doc/APIchanges > https://wiki.libav.org/Migration/12 > > > Diffs > ----- > > src/musicbrainz/MusicDNSAudioDecoder.cpp > 6216e5ce26cc3461b89aea560943ad7a79101af9 > > Diff: https://git.reviewboard.kde.org/r/126682/diff/ > > > Testing > ------- > > I installed the patch on the debian 2.8.0 branch and it build successfully. I > then tried to trigger the affected code, however it crashed because of > https://bugs.kde.org/show_bug.cgi?id=328359 > > > Thanks, > > Diane Trout > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
