Thanks a bunch, Konrad! On Sat, Apr 16, 2016 at 9:23 PM, Konrad Zemek <konrad.ze...@gmail.com> wrote: > (Resending because of my failure to “reply all”) > > Hi, > > This has been fixed in Amarok master: > https://quickgit.kde.org/?p=amarok.git&a=commit&h=fec8817c530ce42b6485fdabff6051784b8d9904 > > Cheers, > Konrad > > On 16 Apr 2016, at 19:18, Michael Palimaka <kensing...@gentoo.org> wrote: > > On 17/04/16 02:46, Myriam Schweingruber wrote: > > On Sat, Apr 16, 2016 at 5:08 PM, Michael Palimaka <kensing...@gentoo.org> > wrote: > > On 16/04/16 20:26, Myriam Schweingruber wrote: > > Hi all, > > On Fri, Apr 15, 2016 at 9:46 AM, Michael Palimaka <kensing...@gentoo.org> > wrote: > > > A few cmake-based revdeps fail to build against it because they do a > string comparison on the version (STRLESS vs VERSION_LESS) so 1.10 > appears too old, but it's an easy fix. > > > Strange, as that particular comparison is in the > FindTaglib-Extras.cmake only, so it should not cause problems with > taglib itself. > > > Right, there's no problem with taglib itself. It's just a heads up that > some revdeps have faulty version detection logic and fail to find 1.10. > > > Does that mean that these lines in FindTaglib.cmake are causing a > problem to find version 1.10? > > if(NOT TAGLIB_MIN_VERSION) > set(TAGLIB_MIN_VERSION "1.6") > endif(NOT TAGLIB_MIN_VERSION) > > > Regards, Myriam > > > See this fix that was applied for kdelibs: > https://quickgit.kde.org/?p=kdelibs.git&a=commitdiff&h=967fc70300d5c2ae34d39b61757b717f6fca8805 > > Some packages (such as taglib-extras-1.0.1 and amarok-2.8.0) ship their > own FindTaglib.cmake that does not contain this fix. Since 1.6 > 1.10 > lexicographically, these unpatched packages will fail to find taglib-1.10. > >
-- Proud member of the Amarok and KDE Community Protect your freedom and join the Fellowship of FSFE: http://www.fsfe.org Please don't send me proprietary file formats, use ISO standard ODF instead (ISO/IEC 26300)
