> On nov. 15, 2015, 2:11 après-midi, Olivier Churlaud wrote: > > Any comments/reviews?
ping ? - Olivier ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126005/#review88383 ----------------------------------------------------------- On nov. 9, 2015, 7:08 après-midi, Olivier Churlaud wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126005/ > ----------------------------------------------------------- > > (Updated nov. 9, 2015, 7:08 après-midi) > > > Review request for Amarok. > > > Repository: amarok > > > Description > ------- > > I port some of the tests.. I would like your feedback on all this. > > > Diffs > ----- > > src/amarokurls/AmarokUrl.cpp e64a1ed > src/browsers/BrowserMessageArea.cpp 13e6dd3 > src/core-impl/meta/cue/CueFileSupport.cpp f39b7eb > src/core-impl/meta/file/File.cpp ac37887 > src/core-impl/meta/timecode/TimecodeTrackProvider.cpp 2c6fd52 > src/core-impl/playlists/types/file/PlaylistFileLoaderJob.cpp a6b448b > src/core-impl/playlists/types/file/asx/ASXPlaylist.cpp 6691a20 > src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp 8330c3d > src/core/support/Amarok.cpp 1d83542 > tests/core-impl/meta/file/TestMetaFileTrack.cpp b1ae0a6 > tests/core-impl/playlists/types/file/asx/TestASXPlaylist.cpp ab97410 > tests/core-impl/playlists/types/file/m3u/TestM3UPlaylist.cpp 41ffa6c > tests/core-impl/playlists/types/file/pls/TestPLSPlaylist.cpp ccf9465 > tests/core-impl/playlists/types/file/xspf/TestXSPFPlaylist.cpp d865213 > tests/core/collections/support/TestTrackForUrlWorker.h 8f6c4aa > tests/core/collections/support/TestTrackForUrlWorker.cpp 7d9bebf > tests/core/meta/TestMetaTrack.h 0859988 > tests/core/meta/TestMetaTrack.cpp 0f5ee16 > tests/dynamic/TestDynamicModel.cpp 43664f5 > tests/timecode/TestTimecodeTrackProvider.cpp 82f66bb > > Diff: https://git.reviewboard.kde.org/r/126005/diff/ > > > Testing > ------- > > compiled and path some tests: > > The following tests FAILED: > 16 - testtrackforurlworker (Failed) > 24 - testplaylistobserver (Failed) > 45 - testtrackloader (Failed) > 46 - testdynamicmodel (Failed) << Corrected but memory leak now. > 49 - testplaylistfileprovider (Failed) > > > Thanks, > > Olivier Churlaud > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
