----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126005/#review88183 -----------------------------------------------------------
src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp (line 401) <https://git.reviewboard.kde.org/r/126005/#comment60475> This line doesn't concern the tests but the sql issue (see mail *Re: [KF5Port] Next-bug: mysql ?* of 07/11/2015 20:15) src/core/support/Amarok.cpp (line 60) <https://git.reviewboard.kde.org/r/126005/#comment60476> This comment should be removed. tests/dynamic/TestDynamicModel.cpp <https://git.reviewboard.kde.org/r/126005/#comment60478> this caused a segfault. Removing it solve the issue but causes a memory leak - Olivier Churlaud On nov. 9, 2015, 1:08 après-midi, Olivier Churlaud wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126005/ > ----------------------------------------------------------- > > (Updated nov. 9, 2015, 1:08 après-midi) > > > Review request for Amarok. > > > Repository: amarok > > > Description > ------- > > I port some of the tests.. I would like your feedback on all this. > > > Diffs > ----- > > src/amarokurls/AmarokUrl.cpp e64a1ed > src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp 441bac4 > src/core-impl/meta/timecode/TimecodeTrackProvider.cpp 2c6fd52 > src/core-impl/playlists/types/file/asx/ASXPlaylist.cpp 6691a20 > src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp 8330c3d > src/core/support/Amarok.cpp 1d83542 > tests/core/collections/support/TestTrackForUrlWorker.cpp 7d9bebf > tests/core/meta/TestMetaTrack.h 0859988 > tests/core/meta/TestMetaTrack.cpp 0f5ee16 > tests/dynamic/TestDynamicModel.cpp 43664f5 > tests/timecode/TestTimecodeTrackProvider.cpp 82f66bb > > Diff: https://git.reviewboard.kde.org/r/126005/diff/ > > > Testing > ------- > > compiled and path some tests: > > 16 - testtrackforurlworker (Failed) > 18 - testmetatrack (Failed) > 26 - testsqldatabaseupdater (Failed) > 27 - testsqlalbum (Failed) > 28 - testsqlartist (Failed) > 29 - testsqlcollection (Failed) > 30 - testsqlquerymaker (Failed) > 31 - testsqlscanmanager (Failed) > 32 - testsqltrack (Failed) > 33 - testsqlcollectionlocation (Failed) > 37 - testcuefilesupport (Failed) > 38 - testmetafiletrack (Failed) > 40 - testasxplaylist (Failed) > 41 - testm3uplaylist (Failed) > 42 - testplsplaylist (Failed) > 43 - testxspfplaylist (Failed) > 45 - testtrackloader (Failed) > 46 - testdynamicmodel (Failed) << Corrected but memory leak now. > 49 - testplaylistfileprovider (Failed) > > > Thanks, > > Olivier Churlaud > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
