> On Aug. 6, 2015, 9:52 p.m., Omar Plummer wrote: > > Ship It!
Ok, I'm not sure what I did there with the "Ship It!" button. I'm new to this reviewborad thing so please forgive any hiccups while I familiarize myself with the rules and procedures. That said; Thanks for the catch there. I've attached a new patch that fixes the aforementioned logic bug. Any pointers on how to proceed would be greatly appreciated. Thanks - Omar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124639/#review83515 ----------------------------------------------------------- On Aug. 6, 2015, 9:45 p.m., Omar Plummer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124639/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2015, 9:45 p.m.) > > > Review request for Amarok. > > > Bugs: https://bugs.kde.org/show_bug.cgi?id=351013 > > https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=351013 > > > Repository: amarok > > > Description > ------- > > Build fails with the following error: > > -- TagLib version too old: version searched :1.7, found 1.10.0 > > > Diffs > ----- > > cmake/modules/FindTaglib.cmake 76b83ac > > Diff: https://git.reviewboard.kde.org/r/124639/diff/ > > > Testing > ------- > > > Thanks, > > Omar Plummer > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
