> On Aug. 6, 2015, 9:59 a.m., Konrad Zemek wrote: > > Actually, there is a bug here. We require at least TagLib 1.7, but after > > your commit that will change to 1.7.1 . `taglib-config --version` returns > > `1.7.0` for TagLib 1.7, and while `"1.7" STRLESS "1.7.0"` is true, `"1.7" > > VERSION_LESS "1.7.0"` is false. > > Omar Plummer wrote: > I'm not sure I follow, so please bear with me if I'm missing something > simple. > > Isn't "1.7" technically equivalent to "1.7.0"? In which case "1.7" < > "1.7.0" should in fact be false?
That's correct, and it is in fact false. :) That's why after your change, when compiled on a system with taglib 1.7, the build will fail with `-- TagLib version too old: version searched :1.7, found 1.7.0` - Konrad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124639/#review83480 ----------------------------------------------------------- On Aug. 6, 2015, 12:57 a.m., Omar Plummer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124639/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2015, 12:57 a.m.) > > > Review request for Amarok. > > > Bugs: https://bugs.kde.org/show_bug.cgi?id=351013 > > https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=351013 > > > Repository: amarok > > > Description > ------- > > Build fails with the following error: > > -- TagLib version too old: version searched :1.7, found 1.10.0 > > > Diffs > ----- > > cmake/modules/FindTaglib.cmake 76b83ac > > Diff: https://git.reviewboard.kde.org/r/124639/diff/ > > > Testing > ------- > > > Thanks, > > Omar Plummer > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
