> On Sept. 5, 2012, 6:19 a.m., Bart Cerneels wrote: > > I would like to see the code you are working on that has a need for this > > change. I still think that it should go directly in core.
Ryan, we are very sorry for any wasted efforts that could have been caused by past Amarok developers telling you to develop in playground while newe ones telling you this should go into core. We are still definitely interested in seeing the Equalizer scripting code. (I'm going to close this review request, it's just lying around, feel engouraged to submit a new one) - Matěj ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103999/#review17841 ----------------------------------------------------------- On Aug. 19, 2012, 10:09 p.m., Ryan McCoskrie wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103999/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2012, 10:09 p.m.) > > > Review request for Amarok. > > > Description > ------- > > This is infrastructure for future patches of mine (specifically equalizer > scripting now that I am back on it). > The intention of this patch is to allow for the /playground directory to > compile code directly into the > Amarok binary. The benefit this has to the Amarok project is that stable > releases can include some experimental > featues that power users can opt into using. > > Changes made to this patch: > 0 Separated from a minor clean up of the playground > 0 Separated from my equalizer scripting code (How on Earth did I overlook > that?) > 0 Added a brief tutorial on compiling in playground code > 0 Now address all platforms, not just those using X11 > 0 Now intended for serious consideration of shipping. > > > Diffs > ----- > > CMakeLists.txt ebb8064 > playground/PLAYER_BINARY.txt PRE-CREATION > playground/src/CMakeLists.txt ed740ec > src/CMakeLists.txt 8596144 > > Diff: http://git.reviewboard.kde.org/r/103999/diff/ > > > Testing > ------- > > Checked that the code compiles with the playground option enabled. > Since there is no active code, this should be sufficiant. > > > Thanks, > > Ryan McCoskrie > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
