> On Feb. 16, 2013, 10:26 a.m., Ralf Engels wrote: > > src/configdialog/dialogs/PlaybackConfig.ui, line 220 > > <http://git.reviewboard.kde.org/r/108964/diff/2/?file=114090#file114090line220> > > > > Could you extend the whatsThis text to indicate what keyboard > > modificators you need to get a "short" "medium" and "long" seek. > > Ralf Engels wrote: > Mamarok mentioned: > [15:33] <Mamarok> rengels: we don't use "What's this" texts anymore since > ages in KDE, he should just document it in the handbook on userbase > [15:42] <Mamarok> here to be precise: > http://userbase.kde.org/Amarok/Manual/References/KeybindingReference/AmarokShortcuts > > I agree with Mamarok which solves my last concern. Should I submit it > like this?
Please wait a day or 2, I'd like to review because I had some ideas.. - Matěj ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108964/#review27540 ----------------------------------------------------------- On Feb. 15, 2013, noon, Anmol Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108964/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2013, noon) > > > Review request for Amarok. > > > Description > ------- > > Added 3 different seek options with customizable seek durations which can be > set in the playback-config: > Control + L/R - Short seek > L/R - Normal/ Medium seek > Shift + L/R - Long seek > > > Diffs > ----- > > src/EngineController.h e9a8c26 > src/EngineController.cpp 3577acf > src/MainWindow.cpp 8f985dc > src/amarokconfig.kcfg 3ebf71d > src/configdialog/dialogs/PlaybackConfig.ui 3a79e43 > > Diff: http://git.reviewboard.kde.org/r/108964/diff/ > > > Testing > ------- > > > Thanks, > > Anmol Ahuja > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
