So all I need to do is add a description of the shortcut keys to the whatsthis text?
Does the following sound okay: The length of a short seek (Control + Left/ Right), in seconds. The length of a medium seek (Left/ Right), in seconds. The length of a long seek (Shift + Left/ Right), in seconds. But these are just the defaults, they can be modified like any other shortcuts, so the whatsthis text might be a little misleading. --- Darth Codus On Sat, Feb 16, 2013 at 3:56 PM, Ralf Engels <ralf-eng...@gmx.de> wrote: > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108964/ > > Technically OK. > This whole seek options bloat up the code a little and the many options bloat > the configuration but still on the good side in my opinion. > Can you add some text about the different keyboard modifiers. It's a little > hard to figure out that there is even such a feature. > > > > src/configdialog/dialogs/PlaybackConfig.ui<http://git.reviewboard.kde.org/r/108964/diff/2/?file=114090#file114090line220> > (Diff > revision 2) > > 220 > > <string>The length of a medium seek, in seconds.</string> > > Could you extend the whatsThis text to indicate what keyboard modificators > you need to get a "short" "medium" and "long" seek. > > > - Ralf > > On February 15th, 2013, noon UTC, Anmol Ahuja wrote: > Review request for Amarok. > By Anmol Ahuja. > > *Updated Feb. 15, 2013, noon* > Description > > Added 3 different seek options with customizable seek durations which can be > set in the playback-config: > Control + L/R - Short seek > L/R - Normal/ Medium seek > Shift + L/R - Long seek > > Diffs > > - src/EngineController.h (e9a8c26) > - src/EngineController.cpp (3577acf) > - src/MainWindow.cpp (8f985dc) > - src/amarokconfig.kcfg (3ebf71d) > - src/configdialog/dialogs/PlaybackConfig.ui (3a79e43) > > View Diff <http://git.reviewboard.kde.org/r/108964/diff/> >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
