----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105285/ -----------------------------------------------------------
(Updated Aug. 15, 2012, 6:47 a.m.) Review request for Amarok. Changes ------- This diff solved all issues listed above. Some new changes: * Return immediately when already logged in as the same user * Clear collection when user changed * Try to login when Amarok is starting Description ------- Things I've done this week: * Added a new playlist provider SpotifyPlaylistProvider * Added playlist class SpotifyPlaylist * Clear all extra whitespaces * Figured out how Collection, QueryMaker and Playlist worked Things need to be done next week: * Clean ScriptResolver's interfaces, move all query related interfaces into Query class * Replace Controller class with ScriptResolver * Test SpotifyCollection * Finish playlist and playlist provider Diffs (updated) ----- src/core-impl/collections/spotifycollection/SpotifyCollection.h PRE-CREATION src/core-impl/collections/spotifycollection/SpotifyCollection.cpp PRE-CREATION src/core-impl/collections/spotifycollection/SpotifyConfig.h PRE-CREATION src/core-impl/collections/spotifycollection/SpotifyConfig.cpp PRE-CREATION src/core-impl/collections/spotifycollection/SpotifyMeta.h PRE-CREATION src/core-impl/collections/spotifycollection/SpotifyMeta.cpp PRE-CREATION src/core-impl/collections/spotifycollection/SpotifyPlaylist.cpp PRE-CREATION src/core-impl/collections/spotifycollection/SpotifyQueryMaker.h PRE-CREATION src/core-impl/collections/spotifycollection/SpotifyQueryMaker.cpp PRE-CREATION src/core-impl/collections/spotifycollection/SpotifySettings.h PRE-CREATION src/core-impl/collections/spotifycollection/SpotifySettings.cpp PRE-CREATION src/core-impl/collections/spotifycollection/support/Controller.h PRE-CREATION src/core-impl/collections/spotifycollection/support/Controller.cpp PRE-CREATION src/core-impl/collections/spotifycollection/support/Query.h PRE-CREATION src/core-impl/collections/spotifycollection/support/Query.cpp PRE-CREATION src/core-impl/collections/spotifycollection/support/TrackProxy.h PRE-CREATION src/core-impl/collections/spotifycollection/support/TrackProxy.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/105285/diff/ Testing ------- No test done this week. Thanks, Zhengliang Feng
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
