----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105285/ -----------------------------------------------------------
(Updated July 13, 2012, 6:04 p.m.) Review request for Amarok. Changes ------- This is the latest diff between my work and master branch of Amarok. Currently this has the following problems: 1. Slot SpotifyQueryMaker::collectResults() will never be executed, I thought it is because the SpotifyQueryMaker is deleted before the results are returned. I added addToCollection() in Query::tracksAdded() to work around this. 2. The results are added to collection correctly, but sometimes the results don't show up in the collection browser. 3. The 'length' or 'duration' of a track is always 0, maybe it's a problem of Spotify resolver. Description ------- Things I've done this week: * Added a new playlist provider SpotifyPlaylistProvider * Added playlist class SpotifyPlaylist * Clear all extra whitespaces * Figured out how Collection, QueryMaker and Playlist worked Things need to be done next week: * Clean ScriptResolver's interfaces, move all query related interfaces into Query class * Replace Controller class with ScriptResolver * Test SpotifyCollection * Finish playlist and playlist provider Diffs (updated) ----- src/core-impl/collections/CMakeLists.txt c78b920 src/core-impl/collections/spotifycollection/CMakeLists.txt PRE-CREATION src/core-impl/collections/spotifycollection/SpotifyCollection.h PRE-CREATION src/core-impl/collections/spotifycollection/SpotifyCollection.cpp PRE-CREATION src/core-impl/collections/spotifycollection/SpotifyMeta.h PRE-CREATION src/core-impl/collections/spotifycollection/SpotifyMeta.cpp PRE-CREATION src/core-impl/collections/spotifycollection/SpotifyPlaylist.h PRE-CREATION src/core-impl/collections/spotifycollection/SpotifyPlaylist.cpp PRE-CREATION src/core-impl/collections/spotifycollection/SpotifyPlaylistProvider.h PRE-CREATION src/core-impl/collections/spotifycollection/SpotifyPlaylistProvider.cpp PRE-CREATION src/core-impl/collections/spotifycollection/SpotifyQueryMaker.h PRE-CREATION src/core-impl/collections/spotifycollection/SpotifyQueryMaker.cpp PRE-CREATION src/core-impl/collections/spotifycollection/support/Controller.h PRE-CREATION src/core-impl/collections/spotifycollection/support/Controller.cpp PRE-CREATION src/core-impl/collections/spotifycollection/support/QMFunctionTypes.h PRE-CREATION src/core-impl/collections/spotifycollection/support/Query.h PRE-CREATION src/core-impl/collections/spotifycollection/support/Query.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/105285/diff/ Testing ------- No test done this week. Thanks, Zhengliang Feng
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
