On Jun 6, 2011, at 2:54 PM, Yuri Pankov wrote: > On Mon, Jun 06, 2011 at 02:19:50PM -0700, Matthew Ahrens wrote: >> I have implemented a new property for ZFS, "refratio", which is the >> compression ratio for referenced space (the "compressratio" is the ratio for >> used space). We are using this here at Delphix to figure out how much space >> a filesystem would use if it was not compressed (ignoring snapshots). I'd >> like to integrate this into Illumos. The changes have been reviewed by >> Delphix folks but it would be nice to get another set of eyes on these 37 >> lines changed. >> >> webrev: >> http://dev1.illumos.org/~eschrock/cr/zfs-refratio/ >> >> bug report: >> https://www.illumos.org/issues/1092 > > Just one question - wouldn't "compressrefratio" (or something similar) > be a better name for the property (I know that it's long, but more > intuitive, in my opinion)?
I'd favor "refcompressratio" otherwise LGTM -- richard _______________________________________________ zfs-discuss mailing list zfs-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/zfs-discuss
