On Thu, Apr 23, 2009 at 11:31:07AM -0500, Nicolas Williams wrote: > On Thu, Apr 23, 2009 at 09:59:33AM -0600, Matthew Ahrens wrote: > > "zfs destroy [-r] -p" sounds great. > > > > I'm not a big fan of the "-t template". Do you have conflicting snapshot > > names due to the way your (zones) software works, or are you concerned > > about sysadmins creating these conflicting snapshots? If it's the former, > > would it be possible to change the zones software to avoid it? > > I think the -t option -- automatic snapshot name conflict resolution -- > makes a lot of sense in the context of snapshots and clones mostly > managed by a system component (zonedm, beadm) but where users can also > create snapshots (e.g., for time slider, backups): you don't want the > users to create snapshot names that will later prevent zoneadm/beadm > destroy. Making the users responsible for resolving such conflicts > seems not user-friendly to me. > > However, if we could just avoid the conflicts in the first place then > we'd not need an option for automatic snapshot name conflict resolution. > Conflicts could be avoided by requiring that all snapshot names of a > dataset and of clones of snapshots of that dataset, and so on, be > unique. Snapshot name uniqueness could be a property of the root > dataset of a snapshot/clone tree. >
an interesting idea. i can file an RFE on this as well, but there are a couple side effects to consider with this approach. setting this property would break "zfs snapshot -r" if there are multiple snapshots and clones of a single filesystem. callers that creates snapshots (ie zones) usually have a simple naming schemes. they look at what snapshots are there and pick a new name that isn't used yet. with this approach, picking a new name becomes harder because iterating over the existing snapshot namespace just became harder. (i guess that callers could adopt a policy of creating snaoshots with incrementing names until they get some return code other than EEXIST.) ed _______________________________________________ zfs-discuss mailing list zfs-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/zfs-discuss
