Good news on the si3124 driver bug I mentioned:
http://mail.opensolaris.org/pipermail/zfs-discuss/2007-May/028487.html
http://mail.opensolaris.org/pipermail/storage-discuss/2007-May/001288.html
Roger Fujii, a long time contributor to the Solaris on x86 list
([EMAIL PROTECTED]), root caused the bug, devised and tested
a fix, and passed the required changes upstream.
I got his permission to forward our email exchange to this list.
PS: will send a separate copy of this email to storage-discuss.
Al Hopper Logical Approach Inc, Plano, TX. [EMAIL PROTECTED]
Voice: 972.379.2133 Fax: 972.379.2134 Timezone: US CDT
OpenSolaris Governing Board (OGB) Member - Apr 2005 to Mar 2007
http://www.opensolaris.org/os/community/ogb/ogb_2005-2007/
---------- Forwarded message ----------
Date: Wed, 06 Jun 2007 12:53:03 -0400
From: Roger Fujii <[EMAIL PROTECTED]>
To: Al Hopper <[EMAIL PROTECTED]>
Subject: Re: [solarisx86] addonics / si3124 controller problem and fix
Al Hopper wrote:
On Wed, 6 Jun 2007, rogerfujii wrote:
Excellent news Roger. Can you email me details of the fix?
it's been assigned CR 6566207 by Linda Bernal. Basically, if you look
at si_intr and read the comments in the code, the bug is pretty
obvious.
Are you working through the OpenSolaris contributor process to
integrate the fix (if so can you send me a pointer to the case
materials)?
Here's what I wrote up:
si3124 driver's interrupt routine is incorrectly coded. The ddi_put32
that clears the interrupts should be enclosed in an "else" block,
thereby making it consistent with the comment just below. Otherwise,
you would be double clearing the interrupts, thus losing pending
interrupts.
Since this is a simple fix, there's really no point dealing it as a
contributor. There also another initialization "bug" I encountered (CR
6565894) which fixed a problem where the drives just didn't show up
after a reboot.
PS: how did you find the bug?
I was determined to add drives to my system. :) Luckily,
SiliconImage has the docs online, plus the code is (relatively) well
commented.
-r
_______________________________________________
zfs-discuss mailing list
zfs-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/zfs-discuss
