> > Note that you'd actually have to verify that the blocks were the same; > > you cannot count on the hash function. If you didn't do this, anyone > > discovering a collision could destroy the colliding blocks/files. > > Given that nobody knows how to find sha256 collisions, you'd of course > need to test this code with a weaker hash algorithm. > > (It would almost be worth it to have the code panic in the event that a > real sha256 collision was found)
The novel discovery of a sha256 collision will be lost on any administrator whose system panics. Imagine how much this will annoy the first customer who accidentally discovers a reproducible test-case. Perhaps generating an FMA error report would be more appropriate? -j _______________________________________________ zfs-discuss mailing list zfs-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/zfs-discuss
